Skip to content

C front-end: support ID_integer-typed expressions in get_c_type #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kroening merged 1 commit into from
Dec 1, 2021
Merged

C front-end: support ID_integer-typed expressions in get_c_type #6030

kroening merged 1 commit into from
Dec 1, 2021

Conversation

@tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Apr 13, 2021

Mathematical integers were wrongly considered "OTHER," resulting in
missing type casts as demonstrated by the included regression test.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig mentioned this pull request Apr 13, 2021
Closed
@codecov
Copy link

codecov bot commented Apr 13, 2021 •
edited
Loading

Codecov Report

Merging #6030 (ef1f40a) into develop (c4deb56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6030   +/-   ##
========================================
  Coverage    75.98%   75.99%           
========================================
  Files         1524     1524           
  Lines       164244   164246    +2     
========================================
+ Hits        124809   124814    +5     
+ Misses       39435    39432    -3
Impacted Files Coverage Δ
src/ansi-c/c_typecast.cpp 79.56% <100.00%> (+0.38%) ⬆️
src/ansi-c/c_typecheck_type.cpp 76.50% <0.00%> (+0.11%) ⬆️
src/util/format_type.cpp 66.15% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62dc70a...ef1f40a. Read the comment docs.

@tautschnig tautschnig force-pushed the integer-promotion branch from d760410 to d98b693 Compare May 7, 2021 06:13
@tautschnig tautschnig force-pushed the integer-promotion branch 2 times, most recently from 7824a1e to 65d210e Compare August 13, 2021 12:40
@tautschnig
C front-end: support ID_integer-typed expressions in get_c_type
ef1f40a 
Mathematical integers were wrongly considered "OTHER," resulting in
missing type casts as demonstrated by the included regression test.
@kroening kroening merged commit dbb6a4d into diffblue:develop Dec 1, 2021
@tautschnig tautschnig deleted the integer-promotion branch December 1, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroening kroening kroening approved these changes

@martin-cs martin-cs martin-cs approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

+1 more reviewer

@NlightNFotis NlightNFotis NlightNFotis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kroening kroening

Labels

bugfix C Front End

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tautschnig @kroening @NlightNFotis @martin-cs